Unverified Commit 7a3f924c authored by Simon Trimmer's avatar Simon Trimmer Committed by Mark Brown
Browse files

firmware: cs_dsp: Add a debugfs entry containing control details 



The file named 'controls' in the DSP's debugfs root contains a
formatted table describing the controls defined within the loaded DSP
firmware, it is of the form

  name: len region:offset addr fwname algid ctltype flags en dirty

Where flags is represented as a character for each flag if set, or '-',
enabled is whether the control is enabled or disabled and dirty is
whether the control value is set in the cache but not the hardware.

Signed-off-by: default avatarSimon Trimmer <simont@opensource.cirrus.com>
Signed-off-by: default avatarRichard Fitzgerald <rf@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20230328131018.6820-1-rf@opensource.cirrus.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent a4d432e9

drivers/firmware/cirrus/cs_dsp.c

+31 −0
Original line number Diff line number Diff line
@@ -14,6 +14,7 @@ 
#include <linux/delay.h>

#include <linux/module.h>

#include <linux/moduleparam.h>

#include <linux/seq_file.h>

#include <linux/slab.h>

#include <linux/vmalloc.h>
@@ -457,6 +458,33 @@ static const struct { 
	},

};



static int cs_dsp_coeff_base_reg(struct cs_dsp_coeff_ctl *ctl, unsigned int *reg,

				 unsigned int off);



static int cs_dsp_debugfs_read_controls_show(struct seq_file *s, void *ignored)

{

	struct cs_dsp *dsp = s->private;

	struct cs_dsp_coeff_ctl *ctl;

	unsigned int reg;



	list_for_each_entry(ctl, &dsp->ctl_list, list) {

		cs_dsp_coeff_base_reg(ctl, &reg, 0);

		seq_printf(s, "%22.*s: %#8zx %s:%08x %#8x %s %#8x %#4x %c%c%c%c %s %s\n",

			   ctl->subname_len, ctl->subname, ctl->len,

			   cs_dsp_mem_region_name(ctl->alg_region.type),

			   ctl->offset, reg, ctl->fw_name, ctl->alg_region.alg, ctl->type,

			   ctl->flags & WMFW_CTL_FLAG_VOLATILE ? 'V' : '-',

			   ctl->flags & WMFW_CTL_FLAG_SYS ? 'S' : '-',

			   ctl->flags & WMFW_CTL_FLAG_READABLE ? 'R' : '-',

			   ctl->flags & WMFW_CTL_FLAG_WRITEABLE ? 'W' : '-',

			   ctl->enabled ? "enabled" : "disabled",

			   ctl->set ? "dirty" : "clean");

	}



	return 0;

}

DEFINE_SHOW_ATTRIBUTE(cs_dsp_debugfs_read_controls);



/**

 * cs_dsp_init_debugfs() - Create and populate DSP representation in debugfs

 * @dsp: pointer to DSP structure
@@ -479,6 +507,9 @@ void cs_dsp_init_debugfs(struct cs_dsp *dsp, struct dentry *debugfs_root) 
		debugfs_create_file(cs_dsp_debugfs_fops[i].name, 0444, root,

				    dsp, &cs_dsp_debugfs_fops[i].fops);



	debugfs_create_file("controls", 0444, root, dsp,

			    &cs_dsp_debugfs_read_controls_fops);



	dsp->debugfs_root = root;

}

EXPORT_SYMBOL_NS_GPL(cs_dsp_init_debugfs, FW_CS_DSP);