Commit 7a4ffec9 authored by Eder Zulian's avatar Eder Zulian Committed by Andrii Nakryiko
Browse files

libsubcmd: Silence compiler warning 



Initialize the pointer 'o' in options__order to NULL to prevent a
compiler warning/error which is observed when compiling with the '-Og'
option, but is not emitted by the compiler with the current default
compilation options.

For example, when compiling libsubcmd with

 $ make "EXTRA_CFLAGS=-Og" -C tools/lib/subcmd/ clean all

Clang version 17.0.6 and GCC 13.3.1 fail to compile parse-options.c due
to following error:

  parse-options.c: In function ‘options__order’:
  parse-options.c:832:9: error: ‘o’ may be used uninitialized [-Werror=maybe-uninitialized]
    832 |         memcpy(&ordered[nr_opts], o, sizeof(*o));
        |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  parse-options.c:810:30: note: ‘o’ was declared here
    810 |         const struct option *o, *p = opts;
        |                              ^
  cc1: all warnings being treated as errors

Signed-off-by: default avatarEder Zulian <ezulian@redhat.com>
Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Acked-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Acked-by: default avatarJiri Olsa <jolsa@kernel.org>
Link: https://lore.kernel.org/bpf/20241022172329.3871958-4-ezulian@redhat.com
parent 7f4ec77f

tools/lib/subcmd/parse-options.c

+1 −1
Original line number Diff line number Diff line
@@ -807,7 +807,7 @@ static int option__cmp(const void *va, const void *vb) 
static struct option *options__order(const struct option *opts)

{

	int nr_opts = 0, nr_group = 0, nr_parent = 0, len;

	const struct option *o, *p = opts;

	const struct option *o = NULL, *p = opts;

	struct option *opt, *ordered = NULL, *group;



	/* flatten the options that have parents */