Commit 7a505a84 authored by Cruise's avatar Cruise Committed by Alex Deucher
Browse files

drm/amd/display: Remove BW Allocation from DPIA notification 



[Why]
USB4 BW Allocation response will be handled in HPD IRQ.
No need to handle it in DPIA notification callback.

[How]
Remove DP BW allocation response code in DPIA notification.

Reviewed-by: default avatarNicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: default avatarCruise <Cruise.Hung@amd.com>
Signed-off-by: default avatarAurabindo Pillai <aurabindo.pillai@amd.com>
Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent c05da59e

drivers/gpu/drm/amd/display/dmub/dmub_srv.h

+0 −4
Original line number Diff line number Diff line
@@ -566,10 +566,6 @@ struct dmub_notification { 
		struct aux_reply_data aux_reply;

		enum dp_hpd_status hpd_status;

		enum set_config_status sc_status;

		/**

		 * DPIA notification command.

		 */

		struct dmub_rb_cmd_dpia_notification dpia_notification;

		struct dmub_rb_cmd_hpd_sense_notify_data hpd_sense_notify;

	};

};

drivers/gpu/drm/amd/display/dmub/src/dmub_srv_stat.c

+0 −17
Original line number Diff line number Diff line
@@ -95,23 +95,6 @@ enum dmub_status dmub_srv_stat_get_notification(struct dmub_srv *dmub, 
	case DMUB_OUT_CMD__DPIA_NOTIFICATION:

		notify->type = DMUB_NOTIFICATION_DPIA_NOTIFICATION;

		notify->link_index = cmd.dpia_notification.payload.header.instance;



		if (cmd.dpia_notification.payload.header.type == DPIA_NOTIFY__BW_ALLOCATION) {



			notify->dpia_notification.payload.data.dpia_bw_alloc.estimated_bw =

					cmd.dpia_notification.payload.data.dpia_bw_alloc.estimated_bw;

			notify->dpia_notification.payload.data.dpia_bw_alloc.allocated_bw =

					cmd.dpia_notification.payload.data.dpia_bw_alloc.allocated_bw;



			if (cmd.dpia_notification.payload.data.dpia_bw_alloc.bits.bw_request_failed)

				notify->result = DPIA_BW_REQ_FAILED;

			else if (cmd.dpia_notification.payload.data.dpia_bw_alloc.bits.bw_request_succeeded)

				notify->result = DPIA_BW_REQ_SUCCESS;

			else if (cmd.dpia_notification.payload.data.dpia_bw_alloc.bits.est_bw_changed)

				notify->result = DPIA_EST_BW_CHANGED;

			else if (cmd.dpia_notification.payload.data.dpia_bw_alloc.bits.bw_alloc_cap_changed)

				notify->result = DPIA_BW_ALLOC_CAPS_CHANGED;

		}

		break;

	case DMUB_OUT_CMD__HPD_SENSE_NOTIFY:

		notify->type = DMUB_NOTIFICATION_HPD_SENSE_NOTIFY;