Commit 7a9f448d authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Martin K. Petersen
Browse files

scsi: ses: Handle positive SCSI error from ses_recv_diag() 



ses_recv_diag() can return a positive value, which also means that an
error happened, so do not only test for negative values.

Cc: James E.J. Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Martin K. Petersen <martin.petersen@oracle.com>
Cc: stable <stable@kernel.org>
Assisted-by: gkh_clanker_2000
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Link: https://patch.msgid.link/2026022301-bony-overstock-a07f@gregkh


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 8ddc0c26

drivers/scsi/ses.c

+1 −1
Original line number Diff line number Diff line
@@ -215,7 +215,7 @@ static unsigned char *ses_get_page2_descriptor(struct enclosure_device *edev, 
	unsigned char *type_ptr = ses_dev->page1_types;

	unsigned char *desc_ptr = ses_dev->page2 + 8;



	if (ses_recv_diag(sdev, 2, ses_dev->page2, ses_dev->page2_len) < 0)

	if (ses_recv_diag(sdev, 2, ses_dev->page2, ses_dev->page2_len))

		return NULL;



	for (i = 0; i < ses_dev->page1_num_types; i++, type_ptr += 4) {