Commit 7b473ae7 authored by Nathan Chancellor's avatar Nathan Chancellor Committed by Greg Kroah-Hartman
Browse files

iio: frequency: adrf6780: Fix adrf6780_spi_{read,write}() 

Clang warns:

drivers/iio/frequency/adrf6780.c:117:1: error: all paths through this
function will call itself [-Werror,-Winfinite-recursion]
{
^
drivers/iio/frequency/adrf6780.c:138:1: error: all paths through this
function will call itself [-Werror,-Winfinite-recursion]
{
^
2 errors generated.

The underscore variants should be used here.

Link: https://github.com/ClangBuiltLinux/linux/issues/1490


Fixes: 63aaf6d0 ("iio: frequency: adrf6780: add support for ADRF6780")
Acked-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarNathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20211022195656.1513147-1-nathan@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b6df1fc1

drivers/iio/frequency/adrf6780.c

+2 −2
Original line number Diff line number Diff line
@@ -118,7 +118,7 @@ static int adrf6780_spi_read(struct adrf6780_state *st, unsigned int reg, 
	int ret;



	mutex_lock(&st->lock);

	ret = adrf6780_spi_read(st, reg, val);

	ret = __adrf6780_spi_read(st, reg, val);

	mutex_unlock(&st->lock);



	return ret;
@@ -139,7 +139,7 @@ static int adrf6780_spi_write(struct adrf6780_state *st, unsigned int reg, 
	int ret;



	mutex_lock(&st->lock);

	ret = adrf6780_spi_write(st, reg, val);

	ret = __adrf6780_spi_write(st, reg, val);

	mutex_unlock(&st->lock);



	return ret;