Commit 7b52ba86 authored by Kory Maincent's avatar Kory Maincent Committed by Vinod Koul
Browse files

dmaengine: dw-edma: Fix wrong interrupt bit set for HDMA 



Instead of setting HDMA_V0_LOCAL_ABORT_INT_EN bit, HDMA_V0_LOCAL_STOP_INT_EN
bit got set twice, due to which the abort interrupt is not getting generated for
HDMA. Fix it by setting the correct interrupt enable bit.

Fixes: e74c3957 ("dmaengine: dw-edma: Add support for native HDMA")
Reviewed-by: default avatarSerge Semin <fancer.lancer@gmail.com>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: default avatarKory Maincent <kory.maincent@bootlin.com>
Link: https://lore.kernel.org/r/20240129-b4-feature_hdma_mainline-v7-2-8e8c1acb7a46@bootlin.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent cd665bfc

drivers/dma/dw-edma/dw-hdma-v0-core.c

+1 −1
Original line number Diff line number Diff line
@@ -236,7 +236,7 @@ static void dw_hdma_v0_core_start(struct dw_edma_chunk *chunk, bool first) 
		/* Interrupt enable&unmask - done, abort */

		tmp = GET_CH_32(dw, chan->dir, chan->id, int_setup) |

		      HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK |

		      HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_LOCAL_STOP_INT_EN;

		      HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_LOCAL_ABORT_INT_EN;

		SET_CH_32(dw, chan->dir, chan->id, int_setup, tmp);

		/* Channel control */

		SET_CH_32(dw, chan->dir, chan->id, control1, HDMA_V0_LINKLIST_EN);