Commit 7b54a96f authored by Sourabh Jain's avatar Sourabh Jain Committed by Andrew Morton
Browse files

crash: remove an unused argument from reserve_crashkernel_generic() 

cmdline argument is not used in reserve_crashkernel_generic() so remove
it.  Correspondingly, all the callers have been updated as well.

No functional change intended.

Link: https://lkml.kernel.org/r/20250131113830.925179-3-sourabhjain@linux.ibm.com


Signed-off-by: default avatarSourabh Jain <sourabhjain@linux.ibm.com>
Acked-by: default avatarHari Bathini <hbathini@linux.ibm.com>
Acked-by: default avatarBaoquan He <bhe@redhat.com>
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>
Cc: Mahesh Salgaonkar <mahesh@linux.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 9986fb51

arch/arm64/mm/init.c

+2 −4
Original line number Diff line number Diff line
@@ -98,21 +98,19 @@ static void __init arch_reserve_crashkernel(void) 
{

	unsigned long long low_size = 0;

	unsigned long long crash_base, crash_size;

	char *cmdline = boot_command_line;

	bool high = false;

	int ret;



	if (!IS_ENABLED(CONFIG_CRASH_RESERVE))

		return;



	ret = parse_crashkernel(cmdline, memblock_phys_mem_size(),

	ret = parse_crashkernel(boot_command_line, memblock_phys_mem_size(),

				&crash_size, &crash_base,

				&low_size, &high);

	if (ret)

		return;



	reserve_crashkernel_generic(cmdline, crash_size, crash_base,

				    low_size, high);

	reserve_crashkernel_generic(crash_size, crash_base, low_size, high);

}



static phys_addr_t __init max_zone_phys(phys_addr_t zone_limit)

arch/loongarch/kernel/setup.c

+2 −3
Original line number Diff line number Diff line
@@ -259,18 +259,17 @@ static void __init arch_reserve_crashkernel(void) 
	int ret;

	unsigned long long low_size = 0;

	unsigned long long crash_base, crash_size;

	char *cmdline = boot_command_line;

	bool high = false;



	if (!IS_ENABLED(CONFIG_CRASH_RESERVE))

		return;



	ret = parse_crashkernel(cmdline, memblock_phys_mem_size(),

	ret = parse_crashkernel(boot_command_line, memblock_phys_mem_size(),

				&crash_size, &crash_base, &low_size, &high);

	if (ret)

		return;



	reserve_crashkernel_generic(cmdline, crash_size, crash_base, low_size, high);

	reserve_crashkernel_generic(crash_size, crash_base, low_size, high);

}



static void __init fdt_setup(void)

arch/riscv/mm/init.c

+2 −4
Original line number Diff line number Diff line
@@ -1396,21 +1396,19 @@ static void __init arch_reserve_crashkernel(void) 
{

	unsigned long long low_size = 0;

	unsigned long long crash_base, crash_size;

	char *cmdline = boot_command_line;

	bool high = false;

	int ret;



	if (!IS_ENABLED(CONFIG_CRASH_RESERVE))

		return;



	ret = parse_crashkernel(cmdline, memblock_phys_mem_size(),

	ret = parse_crashkernel(boot_command_line, memblock_phys_mem_size(),

				&crash_size, &crash_base,

				&low_size, &high);

	if (ret)

		return;



	reserve_crashkernel_generic(cmdline, crash_size, crash_base,

				    low_size, high);

	reserve_crashkernel_generic(crash_size, crash_base, low_size, high);

}



void __init paging_init(void)

arch/x86/kernel/setup.c

+2 −4
Original line number Diff line number Diff line
@@ -472,14 +472,13 @@ static void __init memblock_x86_reserve_range_setup_data(void) 
static void __init arch_reserve_crashkernel(void)

{

	unsigned long long crash_base, crash_size, low_size = 0;

	char *cmdline = boot_command_line;

	bool high = false;

	int ret;



	if (!IS_ENABLED(CONFIG_CRASH_RESERVE))

		return;



	ret = parse_crashkernel(cmdline, memblock_phys_mem_size(),

	ret = parse_crashkernel(boot_command_line, memblock_phys_mem_size(),

				&crash_size, &crash_base,

				&low_size, &high);

	if (ret)
@@ -490,8 +489,7 @@ static void __init arch_reserve_crashkernel(void) 
		return;

	}



	reserve_crashkernel_generic(cmdline, crash_size, crash_base,

				    low_size, high);

	reserve_crashkernel_generic(crash_size, crash_base, low_size, high);

}



static struct resource standard_io_resources[] = {

include/linux/crash_reserve.h

+5 −6
Original line number Diff line number Diff line
@@ -32,13 +32,12 @@ int __init parse_crashkernel(char *cmdline, unsigned long long system_ram, 
#define CRASH_ADDR_HIGH_MAX		memblock_end_of_DRAM()

#endif



void __init reserve_crashkernel_generic(char *cmdline,

		unsigned long long crash_size,

void __init reserve_crashkernel_generic(unsigned long long crash_size,

					unsigned long long crash_base,

					unsigned long long crash_low_size,

					bool high);

#else

static inline void __init reserve_crashkernel_generic(char *cmdline,

static inline void __init reserve_crashkernel_generic(

		unsigned long long crash_size,

		unsigned long long crash_base,

		unsigned long long crash_low_size,