Commit 7b764483 authored by Keita Morisaki's avatar Keita Morisaki Committed by Ulf Hansson
Browse files

cpuidle: psci: Add trace for PSCI domain idle 



The trace event cpu_idle provides insufficient information for debugging
PSCI requests due to lacking access to determined PSCI domain idle
states. The cpu_idle usually only shows -1, 0, or 1 regardless how many
idle states the power domain has.

Add new trace events namely psci_domain_idle_enter and
psci_domain_idle_exit to trace enter and exit events with a determined
idle state.

These new trace events will help developers debug CPUidle issues on ARM
systems using PSCI by providing more detailed information about the
requested idle states.

Signed-off-by: default avatarKeita Morisaki <keyz@google.com>
Reviewed-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
Reviewed-by: default avatarDhruva Gole <d-gole@ti.com>
Tested-by: default avatarKevin Hilman <khilman@baylibre.com>
Acked-by: default avatarSudeep Holla <sudeep.holla@arm.com>
Link: https://lore.kernel.org/r/20250210055828.1875372-1-keyz@google.com


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent c2851be5

drivers/cpuidle/cpuidle-psci.c

+3 −0
Original line number Diff line number Diff line
@@ -25,6 +25,7 @@ 
#include <linux/syscore_ops.h>



#include <asm/cpuidle.h>

#include <trace/events/power.h>



#include "cpuidle-psci.h"

#include "dt_idle_states.h"
@@ -74,7 +75,9 @@ static __cpuidle int __psci_enter_domain_idle_state(struct cpuidle_device *dev, 
	if (!state)

		state = states[idx];



	trace_psci_domain_idle_enter(dev->cpu, state, s2idle);

	ret = psci_cpu_suspend_enter(state) ? -1 : idx;

	trace_psci_domain_idle_exit(dev->cpu, state, s2idle);



	if (s2idle)

		dev_pm_genpd_resume(pd_dev);

include/trace/events/power.h

+37 −0
Original line number Diff line number Diff line
@@ -62,6 +62,43 @@ TRACE_EVENT(cpu_idle_miss, 
		(unsigned long)__entry->state, (__entry->below)?"below":"above")

);



DECLARE_EVENT_CLASS(psci_domain_idle,



	TP_PROTO(unsigned int cpu_id, unsigned int state, bool s2idle),



	TP_ARGS(cpu_id, state, s2idle),



	TP_STRUCT__entry(

		__field(u32,		cpu_id)

		__field(u32,		state)

		__field(bool,		s2idle)

	),



	TP_fast_assign(

		__entry->cpu_id = cpu_id;

		__entry->state = state;

		__entry->s2idle = s2idle;

	),



	TP_printk("cpu_id=%lu state=0x%lx is_s2idle=%s",

		  (unsigned long)__entry->cpu_id, (unsigned long)__entry->state,

		  (__entry->s2idle)?"yes":"no")

);



DEFINE_EVENT(psci_domain_idle, psci_domain_idle_enter,



	TP_PROTO(unsigned int cpu_id, unsigned int state, bool s2idle),



	TP_ARGS(cpu_id, state, s2idle)

);



DEFINE_EVENT(psci_domain_idle, psci_domain_idle_exit,



	TP_PROTO(unsigned int cpu_id, unsigned int state, bool s2idle),



	TP_ARGS(cpu_id, state, s2idle)

);



TRACE_EVENT(powernv_throttle,



	TP_PROTO(int chip_id, const char *reason, int pmax),