Commit 7b779417 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Lucas De Marchi
Browse files

drm/xe/hwmon: Use devm_mutex_init() 



Use devm_mutex_init() instead of hand-writing it.

This saves some LoC, improves readability and saves some space in the
generated .o file.

Before:
======
   text	   data	    bss	    dec	    hex	filename
  36884	  10296	     64	  47244	   b88c	drivers/gpu/drm/xe/xe_hwmon.o

After:
=====
   text	   data	    bss	    dec	    hex	filename
  36651	  10224	     64	  46939	   b75b	drivers/gpu/drm/xe/xe_hwmon.o

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarStuart Summers <stuart.summers@intel.com>
Link: https://lore.kernel.org/r/989e96369e9e1f8a44b816962917ec76877c912d.1757252520.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
parent e57ae80f

drivers/gpu/drm/xe/xe_hwmon.c

+1 −9
Original line number Diff line number Diff line
@@ -1294,13 +1294,6 @@ xe_hwmon_get_preregistration_info(struct xe_hwmon *hwmon) 
			xe_hwmon_fan_input_read(hwmon, channel, &fan_speed);

}



static void xe_hwmon_mutex_destroy(void *arg)

{

	struct xe_hwmon *hwmon = arg;



	mutex_destroy(&hwmon->hwmon_lock);

}



int xe_hwmon_register(struct xe_device *xe)

{

	struct device *dev = xe->drm.dev;
@@ -1319,8 +1312,7 @@ int xe_hwmon_register(struct xe_device *xe) 
	if (!hwmon)

		return -ENOMEM;



	mutex_init(&hwmon->hwmon_lock);

	ret = devm_add_action_or_reset(dev, xe_hwmon_mutex_destroy, hwmon);

	ret = devm_mutex_init(dev, &hwmon->hwmon_lock);

	if (ret)

		return ret;