Commit 7bbfb255 authored by John B. Moore's avatar John B. Moore Committed by Alex Deucher
Browse files

drm/amdgpu/gfx9: drop unnecessary 64-bit fence flag check in KIQ 



Remove the BUG_ON(flags & AMDGPU_FENCE_FLAG_64BIT) assertion from
gfx_v9_0_ring_emit_fence_kiq().  The KIQ hardware supports 64-bit
fence writes; the 32-bit writeback address constraint is an
upper-layer convention, not a hardware limitation.  The check serves
no purpose and should not be present.

Found by code inspection while investigating related BUG_ON
assertions in the GFX and compute ring emission paths.

Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarJohn B. Moore <jbmoore61@gmail.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
(cherry picked from commit 1b1101a46a426bb4328116bb5273c326a2780389)
Cc: stable@vger.kernel.org
parent 9b4e3495

drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c

+0 −3
Original line number Diff line number Diff line
@@ -5660,9 +5660,6 @@ static void gfx_v9_0_ring_emit_fence_kiq(struct amdgpu_ring *ring, u64 addr, 
{

	struct amdgpu_device *adev = ring->adev;



	/* we only allocate 32bit for each seq wb address */

	BUG_ON(flags & AMDGPU_FENCE_FLAG_64BIT);



	/* write fence seq to the "addr" */

	amdgpu_ring_write(ring, PACKET3(PACKET3_WRITE_DATA, 3));

	amdgpu_ring_write(ring, (WRITE_DATA_ENGINE_SEL(0) |