Commit 7bc09f7e authored by Jerome Brunet's avatar Jerome Brunet Committed by Takashi Iwai
Browse files

ASoC: cs35l34: drop useless rate contraint 



The cs35l34 adds a useless rate constraint on startup.
It does not set SNDRV_PCM_RATE_KNOT and the rates set are already a subset
of the ones provided in the constraint list, so it is a no-op.

>From the rest of the code, it is likely HW supports more than the 32, 44.1
and 48kHz listed in CS35L34_RATES but there is no way to know for sure
without proper documentation.

Keep the driver as it is for now and just drop the useless constraint.

Signed-off-by: default avatarJerome Brunet <jbrunet@baylibre.com>
Reviewed-by: default avatarDavid Rhodes <drhodes@opensource.cirrus.com>
Acked-by: default avatarMark Brown <broonie@kernel.org>
Reviewed-by: default avatarJaroslav Kysela <perex@perex.cz>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20240905-alsa-12-24-128-v1-12-8371948d3921@baylibre.com
parent 9dc03a12

sound/soc/codecs/cs35l34.c

+0 −21
Original line number Diff line number Diff line
@@ -562,26 +562,6 @@ static int cs35l34_pcm_hw_params(struct snd_pcm_substream *substream, 
	return ret;

}



static const unsigned int cs35l34_src_rates[] = {

	8000, 11025, 12000, 16000, 22050, 24000, 32000, 44100, 48000

};





static const struct snd_pcm_hw_constraint_list cs35l34_constraints = {

	.count  = ARRAY_SIZE(cs35l34_src_rates),

	.list   = cs35l34_src_rates,

};



static int cs35l34_pcm_startup(struct snd_pcm_substream *substream,

			       struct snd_soc_dai *dai)

{



	snd_pcm_hw_constraint_list(substream->runtime, 0,

				SNDRV_PCM_HW_PARAM_RATE, &cs35l34_constraints);

	return 0;

}





static int cs35l34_set_tristate(struct snd_soc_dai *dai, int tristate)

{
@@ -639,7 +619,6 @@ static int cs35l34_dai_set_sysclk(struct snd_soc_dai *dai, 
}



static const struct snd_soc_dai_ops cs35l34_ops = {

	.startup = cs35l34_pcm_startup,

	.set_tristate = cs35l34_set_tristate,

	.set_fmt = cs35l34_set_dai_fmt,

	.hw_params = cs35l34_pcm_hw_params,