Commit 7bdf59c7 authored by Jiri Slaby (SUSE)'s avatar Jiri Slaby (SUSE) Committed by Greg Kroah-Hartman
Browse files

serial: 8250: extract serial8250_init_mctrl() 



After commit 79515869 ("serial: 8250: extract
serial8250_initialize()"), split serial8250_initialize() even more --
the mctrl part of this code can be separated into
serial8250_init_mctrl() -- done now.

Signed-off-by: default avatar"Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Suggested-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20250624080641.509959-2-jirislaby@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d22cf138

drivers/tty/serial/8250/8250_port.c

+13 −8
Original line number Diff line number Diff line
@@ -2216,15 +2216,8 @@ static void serial8250_THRE_test(struct uart_port *port) 
		up->bugs |= UART_BUG_THRE;

}



static void serial8250_initialize(struct uart_port *port)

static void serial8250_init_mctrl(struct uart_port *port)

{

	struct uart_8250_port *up = up_to_u8250p(port);

	unsigned long flags;

	bool lsr_TEMT, iir_NOINT;



	serial_port_out(port, UART_LCR, UART_LCR_WLEN8);



	uart_port_lock_irqsave(port, &flags);

	if (port->flags & UPF_FOURPORT) {

		if (!port->irq)

			port->mctrl |= TIOCM_OUT1;
@@ -2235,6 +2228,18 @@ static void serial8250_initialize(struct uart_port *port) 
	}



	serial8250_set_mctrl(port, port->mctrl);

}



static void serial8250_initialize(struct uart_port *port)

{

	struct uart_8250_port *up = up_to_u8250p(port);

	unsigned long flags;

	bool lsr_TEMT, iir_NOINT;



	serial_port_out(port, UART_LCR, UART_LCR_WLEN8);



	uart_port_lock_irqsave(port, &flags);

	serial8250_init_mctrl(port);



	/*

	 * Serial over Lan (SoL) hack: