Commit 7bf1001e authored by Rob Herring (Arm)'s avatar Rob Herring (Arm) Committed by Will Deacon
Browse files

perf: arm_v7_pmu: Don't disable counter in (armv7|krait_|scorpion_)pmu_enable_event() 



Currently (armv7|krait_|scorpion_)pmu_enable_event() start by disabling
the event counter it has been asked to enable. This should not be
necessary as the counter (and the PMU as a whole) should not be active
when *_enable_event() is called.

Signed-off-by: default avatarRob Herring (Arm) <robh@kernel.org>
Reviewed-by: default avatarAnshuman Khandual <anshuman.khandual@arm.com>
Tested-by: default avatarJames Clark <james.clark@linaro.org>
Link: https://lore.kernel.org/r/20250218-arm-brbe-v19-v20-5-4e9922fc2e8e@kernel.org


Signed-off-by: default avatarWill Deacon <will@kernel.org>
parent 7a538774

drivers/perf/arm_v7_pmu.c

+0 −6
Original line number Diff line number Diff line
@@ -857,8 +857,6 @@ static void armv7pmu_enable_event(struct perf_event *event) 
		return;

	}



	armv7_pmnc_disable_counter(idx);



	/*

	 * Set event (if destined for PMNx counters)

	 * We only need to set the event for the cycle counter if we
@@ -1450,8 +1448,6 @@ static void krait_pmu_enable_event(struct perf_event *event) 
	struct hw_perf_event *hwc = &event->hw;

	int idx = hwc->idx;



	armv7_pmnc_disable_counter(idx);



	/*

	 * Set event (if destined for PMNx counters)

	 * We set the event for the cycle counter because we
@@ -1762,8 +1758,6 @@ static void scorpion_pmu_enable_event(struct perf_event *event) 
	struct hw_perf_event *hwc = &event->hw;

	int idx = hwc->idx;



	armv7_pmnc_disable_counter(idx);



	/*

	 * Set event (if destined for PMNx counters)

	 * We don't set the event for the cycle counter because we