Commit 7c4f78cd authored by Ignat Korchagin's avatar Ignat Korchagin Committed by Jakub Kicinski
Browse files

Bluetooth: L2CAP: do not leave dangling sk pointer on error in l2cap_sock_create() 



bt_sock_alloc() allocates the sk object and attaches it to the provided
sock object. On error l2cap_sock_alloc() frees the sk object, but the
dangling pointer is still attached to the sock object, which may create
use-after-free in other code.

Signed-off-by: default avatarIgnat Korchagin <ignat@cloudflare.com>
Reviewed-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Reviewed-by: default avatarEric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20241014153808.51894-3-ignat@cloudflare.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 46f2a11c

net/bluetooth/l2cap_sock.c

+1 −0
Original line number Diff line number Diff line
@@ -1886,6 +1886,7 @@ static struct sock *l2cap_sock_alloc(struct net *net, struct socket *sock, 
	chan = l2cap_chan_create();

	if (!chan) {

		sk_free(sk);

		sock->sk = NULL;

		return NULL;

	}