Commit 7c79b8aa authored by Jani Nikula's avatar Jani Nikula
Browse files

drm/i915/audio: drop irq enabled check from LPE audio setup



There shouldn't be anything requiring irqs to be enabled at the point of
LPE audio setup. Regardless, we've never hit the warning, as irqs are
always enabled at the time LPE audio is initialized. Drop the
superfluous warning, and the dependency on i915_drv.h.

Fix style a bit while at it.

Reviewed-by: default avatarVinod Govindapillai <vinod.govindapillai@intel.com>
Link: https://lore.kernel.org/r/20250801122832.249985-1-jani.nikula@intel.com


Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
parent ada8faab
Loading
Loading
Loading
Loading
+4 −7
Original line number Diff line number Diff line
@@ -68,9 +68,9 @@
#include <linux/platform_device.h>
#include <linux/pm_runtime.h>

#include <drm/drm_print.h>
#include <drm/intel/intel_lpe_audio.h>

#include "i915_drv.h"
#include "i915_irq.h"
#include "intel_audio_regs.h"
#include "intel_de.h"
@@ -170,12 +170,9 @@ static struct irq_chip lpe_audio_irqchip = {

static int lpe_audio_irq_init(struct intel_display *display)
{
	struct drm_i915_private *dev_priv = to_i915(display->drm);
	int irq = display->audio.lpe.irq;

	drm_WARN_ON(display->drm, !intel_irqs_enabled(dev_priv));
	irq_set_chip_and_handler_name(irq,
				&lpe_audio_irqchip,
	irq_set_chip_and_handler_name(irq, &lpe_audio_irqchip,
				      handle_simple_irq,
				      "hdmi_lpe_audio_irq_handler");