Commit 7c7be683 authored by Jose Ignacio Tornos Martinez's avatar Jose Ignacio Tornos Martinez Committed by David S. Miller
Browse files

net: usb: ax88179_178a: non necessary second random mac address 



If the mac address can not be read from the device registers or the
devicetree, a random address is generated, but this was already done from
usbnet_probe, so it is not necessary to call eth_hw_addr_random from here
again to generate another random address.

Indeed, when reset was also executed from bind, generate another random mac
address invalidated the check from usbnet_probe to configure if the assigned
mac address for the interface was random or not, because it is comparing
with the initial generated random address. Now, with only a reset from open
operation, it is just a harmless simplification.

Signed-off-by: default avatarJose Ignacio Tornos Martinez <jtornosm@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cd8a34cb

drivers/net/usb/ax88179_178a.c

+0 −1
Original line number Diff line number Diff line
@@ -1277,7 +1277,6 @@ static void ax88179_get_mac_addr(struct usbnet *dev) 
			dev->net->addr_assign_type = NET_ADDR_PERM;

	} else {

		netdev_info(dev->net, "invalid MAC address, using random\n");

		eth_hw_addr_random(dev->net);

	}



	ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_NODE_ID, ETH_ALEN, ETH_ALEN,