Commit 7c876530 authored by Christian Marangi's avatar Christian Marangi Committed by Vinod Koul
Browse files

dmaengine: qcom-adm: fix wrong sizeof config in slave_config 



Fix broken slave_config function that uncorrectly compare the
peripheral_size with the size of the config pointer instead of the size
of the config struct. This cause the crci value to be ignored and cause
a kernel panic on any slave that use adm driver.

To fix this, compare to the size of the struct and NOT the size of the
pointer.

Fixes: 03de6b27 ("dmaengine: qcom-adm: stop abusing slave_id config")
Signed-off-by: default avatarChristian Marangi <ansuelsmth@gmail.com>
Cc: stable@vger.kernel.org # v5.17+
Reviewed-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20220915204844.3838-1-ansuelsmth@gmail.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 693e9c26

drivers/dma/qcom/qcom_adm.c

+1 −1
Original line number Diff line number Diff line
@@ -494,7 +494,7 @@ static int adm_slave_config(struct dma_chan *chan, struct dma_slave_config *cfg) 


	spin_lock_irqsave(&achan->vc.lock, flag);

	memcpy(&achan->slave, cfg, sizeof(struct dma_slave_config));

	if (cfg->peripheral_size == sizeof(config))

	if (cfg->peripheral_size == sizeof(*config))

		achan->crci = config->crci;

	spin_unlock_irqrestore(&achan->vc.lock, flag);