Commit 7c942f87 authored by Dev Jain's avatar Dev Jain Committed by Andrew Morton
Browse files

selftests/mm: fix validate_addr() helper 

validate_addr() checks whether the address returned by mmap() lies in the
low or high VA space, according to whether a high addr hint was passed or
not.  The fix commit mentioned below changed the code in such a way that
this function will always return failure when passed high_addr == 1; addr
will be >= HIGH_ADDR_MARK always, we will fall down to "if (addr >
HIGH_ADDR_MARK)" and return failure.  Fix this.

Link: https://lkml.kernel.org/r/20250620111150.50344-1-dev.jain@arm.com


Fixes: d1d86ce2 ("selftests/mm: virtual_address_range: conform to TAP format output")
Signed-off-by: default avatarDev Jain <dev.jain@arm.com>
Reviewed-by: default avatarDonet Tom <donettom@linux.ibm.com>
Acked-by: default avatarDavid Hildenbrand <david@redhat.com>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Cc: Shuah Khan <shuah@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent b6f5e748

tools/testing/selftests/mm/virtual_address_range.c

+5 −2
Original line number Diff line number Diff line
@@ -77,8 +77,11 @@ static void validate_addr(char *ptr, int high_addr) 
{

	unsigned long addr = (unsigned long) ptr;



	if (high_addr && addr < HIGH_ADDR_MARK)

	if (high_addr) {

		if (addr < HIGH_ADDR_MARK)

			ksft_exit_fail_msg("Bad address %lx\n", addr);

		return;

	}



	if (addr > HIGH_ADDR_MARK)

		ksft_exit_fail_msg("Bad address %lx\n", addr);