Commit 7cb0e699 authored by Colin Ian King's avatar Colin Ian King Committed by Kent Overstreet
Browse files

bcachefs: remove redundant initialization of pointer d 



The pointer d is being initialized with a value that is never read,
it is being re-assigned later on when it is used in a for-loop.
The initialization is redundant and can be removed.

Cleans up clang-scan build warning:
fs/bcachefs/buckets.c:1303:25: warning: Value stored to 'd' during its
initialization is never read [deadcode.DeadStores]

Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
Signed-off-by: default avatarKent Overstreet <kent.overstreet@linux.dev>
parent feb5cc39

fs/bcachefs/btree_update_interior.c

+1 −1
Original line number Diff line number Diff line
@@ -143,7 +143,7 @@ static size_t btree_node_u64s_with_format(struct btree *b, 
}



/**

 * btree_node_format_fits - check if we could rewrite node with a new format

 * bch2_btree_node_format_fits - check if we could rewrite node with a new format

 *

 * This assumes all keys can pack with the new format -- it just checks if

 * the re-packed keys would fit inside the node itself.

fs/bcachefs/buckets.c

+1 −1
Original line number Diff line number Diff line
@@ -1300,7 +1300,7 @@ int bch2_trans_fs_usage_apply(struct btree_trans *trans, 
	static int warned_disk_usage = 0;

	bool warn = false;

	unsigned disk_res_sectors = trans->disk_res ? trans->disk_res->sectors : 0;

	struct replicas_delta *d = deltas->d, *d2;

	struct replicas_delta *d, *d2;

	struct replicas_delta *top = (void *) deltas->d + deltas->used;

	struct bch_fs_usage *dst;

	s64 added = 0, should_not_have_added;