Commit 7cb53e28 authored by Guenter Roeck's avatar Guenter Roeck
Browse files

hwmon: (adm1025) Fix overflows seen when writing voltage limits 



Writes into voltage limit attributes can overflow due to an unbound
multiplication.

Reviewed-by: default avatarJean Delvare <jdelvare@suse.de>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent df60d701

drivers/hwmon/adm1025.c

+1 −1
Original line number Diff line number Diff line
@@ -93,7 +93,7 @@ static const int in_scale[6] = { 2500, 2250, 3300, 5000, 12000, 3300 }; 


#define IN_FROM_REG(reg, scale)	(((reg) * (scale) + 96) / 192)

#define IN_TO_REG(val, scale)	((val) <= 0 ? 0 : \

				 (val) * 192 >= (scale) * 255 ? 255 : \

				 (val) >= (scale) * 255 / 192 ? 255 : \

				 ((val) * 192 + (scale) / 2) / (scale))



#define TEMP_FROM_REG(reg)	((reg) * 1000)