Commit 7cc3fe8e authored by Julia Lawall's avatar Julia Lawall Committed by Steven Rostedt (Google)
Browse files

tracing: Drop unneeded assignment to soft_mode 

soft_mode is not read in the enable case, so drop the assignment.
Drop also the comment text that refers to the assignment and realign
the comment.

Cc: "Paul E . McKenney" <paulmck@kernel.org>
Cc: Gabriele Paoloni <gpaoloni@redhat.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Link: https://patch.msgid.link/20251226110531.4129794-1-Julia.Lawall@inria.fr


Signed-off-by: default avatarJulia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent 9ace4753

kernel/trace/trace_events.c

+3 −4
Original line number Diff line number Diff line
@@ -826,16 +826,15 @@ static int __ftrace_event_enable_disable(struct trace_event_file *file, 
		 * When soft_disable is set and enable is set, we want to

		 * register the tracepoint for the event, but leave the event

		 * as is. That means, if the event was already enabled, we do

		 * nothing (but set soft_mode). If the event is disabled, we

		 * set SOFT_DISABLED before enabling the event tracepoint, so

		 * it still seems to be disabled.

		 * nothing. If the event is disabled, we set SOFT_DISABLED

		 * before enabling the event tracepoint, so it still seems

		 * to be disabled.

		 */

		if (!soft_disable)

			clear_bit(EVENT_FILE_FL_SOFT_DISABLED_BIT, &file->flags);

		else {

			if (atomic_inc_return(&file->sm_ref) > 1)

				break;

			soft_mode = true;

			/* Enable use of trace_buffered_event */

			trace_buffered_event_enable();

		}