Commit 7cc47e64 authored by Mingzhe Zou's avatar Mingzhe Zou Committed by Jens Axboe
Browse files

bcache: fixup init dirty data errors 



We found that after long run, the dirty_data of the bcache device
will have errors. This error cannot be eliminated unless re-register.

We also found that reattach after detach, this error can accumulate.

In bch_sectors_dirty_init(), all inode <= d->id keys will be recounted
again. This is wrong, we only need to count the keys of the current
device.

Fixes: b144e45f ("bcache: make bch_sectors_dirty_init() to be multithreaded")
Signed-off-by: default avatarMingzhe Zou <mingzhe.zou@easystack.cn>
Cc:  <stable@vger.kernel.org>
Signed-off-by: default avatarColy Li <colyli@suse.de>
Link: https://lore.kernel.org/r/20231120052503.6122-6-colyli@suse.de


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 2c7f497a

drivers/md/bcache/writeback.c

+4 −1
Original line number Diff line number Diff line
@@ -991,8 +991,11 @@ void bch_sectors_dirty_init(struct bcache_device *d) 
		op.count = 0;



		for_each_key_filter(&c->root->keys,

				    k, &iter, bch_ptr_invalid)

				    k, &iter, bch_ptr_invalid) {

			if (KEY_INODE(k) != op.inode)

				continue;

			sectors_dirty_init_fn(&op.op, c->root, k);

		}



		rw_unlock(0, c->root);

		return;