Commit 7ceade65 authored Jan 30, 2024 by Kalle Valo

wifi: cw1200: fix __le16 sparse warnings

Sparse warns:

drivers/net/wireless/st/cw1200/cw1200_spi.c:83:17: got restricted __le16 [usertype]
drivers/net/wireless/st/cw1200/cw1200_spi.c:148:17: warning: incorrect type in assignment (different base types)
drivers/net/wireless/st/cw1200/cw1200_spi.c:148:17: expected unsigned short [addressable] [assigned] [usertype] regaddr
drivers/net/wireless/st/cw1200/cw1200_spi.c:148:17: got restricted __le16 [usertype]

These cpu_to_le16() calls are not really making any sense to me. On a big
endian system we first convert regaddr from big to little using cpu_to_le16()
but immediately after we convert them back to big endian? So just remove them.

Compile tested only.

Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://msgid.link/20240130151556.2315951-4-kvalo@kernel.org

parent 0583e5ac

drivers/net/wireless/st/cw1200/cw1200_spi.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -79,9 +79,6 @@ static int cw1200_spi_memcpy_fromio(struct hwbus_priv *self,
		pr_info("READ : %04d from 0x%02x (%04x)\n", count, addr, regaddr);
		#endif

		/* Header is LE16 */
		regaddr = cpu_to_le16(regaddr);

		/* We have to byteswap if the SPI bus is limited to 8b operation
		or we are running on a Big Endian system
		*/
		@@ -144,9 +141,6 @@ static int cw1200_spi_memcpy_toio(struct hwbus_priv *self,
		pr_info("WRITE: %04d to 0x%02x (%04x)\n", count, addr, regaddr);
		#endif

		/* Header is LE16 */
		regaddr = cpu_to_le16(regaddr);

		/* We have to byteswap if the SPI bus is limited to 8b operation
		or we are running on a Big Endian system
		*/