Commit 7d02ba96 authored by Jeff Layton's avatar Jeff Layton Committed by Jakub Kicinski
Browse files

ref_tracker: don't use %pK in pr_ostream() output 

As Thomas Weißschuh points out [1], it is now preferable to use %p
instead of hashed pointers with printk(), since raw pointers should no
longer be leaked into the kernel log. Change the ref_tracker
infrastructure to use %p instead of %pK in its formats.

[1]: https://lore.kernel.org/netdev/20250414-restricted-pointers-net-v1-0-12af0ce46cdd@linutronix.de/



Reviewed-by: default avatarThomas Weißschuh <thomas.weissschuh@linutronix.de>
Reviewed-by: default avatarKrzysztof Karas <krzysztof.karas@intel.com>
Signed-off-by: default avatarJeff Layton <jlayton@kernel.org>
Link: https://patch.msgid.link/20250618-reftrack-dbgfs-v15-1-24fc37ead144@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e04c78d8

lib/ref_tracker.c

+3 −3
Original line number Diff line number Diff line
@@ -96,7 +96,7 @@ __ref_tracker_dir_pr_ostream(struct ref_tracker_dir *dir, 


	stats = ref_tracker_get_stats(dir, display_limit);

	if (IS_ERR(stats)) {

		pr_ostream(s, "%s@%pK: couldn't get stats, error %pe\n",

		pr_ostream(s, "%s@%p: couldn't get stats, error %pe\n",

			   dir->name, dir, stats);

		return;

	}
@@ -107,13 +107,13 @@ __ref_tracker_dir_pr_ostream(struct ref_tracker_dir *dir, 
		stack = stats->stacks[i].stack_handle;

		if (sbuf && !stack_depot_snprint(stack, sbuf, STACK_BUF_SIZE, 4))

			sbuf[0] = 0;

		pr_ostream(s, "%s@%pK has %d/%d users at\n%s\n", dir->name, dir,

		pr_ostream(s, "%s@%p has %d/%d users at\n%s\n", dir->name, dir,

			   stats->stacks[i].count, stats->total, sbuf);

		skipped -= stats->stacks[i].count;

	}



	if (skipped)

		pr_ostream(s, "%s@%pK skipped reports about %d/%d users.\n",

		pr_ostream(s, "%s@%p skipped reports about %d/%d users.\n",

			   dir->name, dir, skipped, stats->total);



	kfree(sbuf);