Commit 7d0b3953 authored by Andrii Nakryiko's avatar Andrii Nakryiko Committed by Alexei Starovoitov
Browse files

libbpf: don't close(-1) in multi-uprobe feature detector 



Guard close(link_fd) with extra link_fd >= 0 check to prevent close(-1).

Detected by Coverity static analysis.

Fixes: 04d939a2 ("libbpf: detect broken PID filtering logic for multi-uprobe")
Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Acked-by: default avatarJiri Olsa <jolsa@kernel.org>
Link: https://lore.kernel.org/r/20240529231212.768828-1-andrii@kernel.org


Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent aeb8fe02

tools/lib/bpf/features.c

+2 −1
Original line number Diff line number Diff line
@@ -393,6 +393,7 @@ static int probe_uprobe_multi_link(int token_fd) 
	err = -errno; /* close() can clobber errno */



	if (link_fd >= 0 || err != -EBADF) {

		if (link_fd >= 0)

			close(link_fd);

		close(prog_fd);

		return 0;