Commit 7d12970f authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

firmware: dmi-sysfs: make pr_info messages rate limited 



Currently if a process repeat repeatedly reads the dmi sysfs raw event log
/sys/firmware/dmi/entries/15-0/system_event_log/raw_event_log when GPNV
support is missing or using an unknown access method the kernel log gets
spammed with info messages. Make the messages rate limited to reduce the
message spamming. Triggered when running sudo stress-ng --sysfs -t 5m.

Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
Link: https://lore.kernel.org/r/20221129223855.1005674-1-colin.i.king@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 11819ed2

drivers/firmware/dmi-sysfs.c

+2 −2
Original line number Diff line number Diff line
@@ -418,10 +418,10 @@ static ssize_t dmi_sel_raw_read_helper(struct dmi_sysfs_entry *entry, 
		return dmi_sel_raw_read_phys32(entry, &sel, state->buf,

					       state->pos, state->count);

	case DMI_SEL_ACCESS_METHOD_GPNV:

		pr_info("dmi-sysfs: GPNV support missing.\n");

		pr_info_ratelimited("dmi-sysfs: GPNV support missing.\n");

		return -EIO;

	default:

		pr_info("dmi-sysfs: Unknown access method %02x\n",

		pr_info_ratelimited("dmi-sysfs: Unknown access method %02x\n",

			sel.access_method);

		return -EIO;

	}