Commit 7d493a5e authored by Josef Bacik's avatar Josef Bacik Committed by David Sterba
Browse files

btrfs: fix incorrect comparison for delayed refs 



When I reworked delayed ref comparison in cf4f0432 ("btrfs: move
->parent and ->ref_root into btrfs_delayed_ref_node"), I made a mistake
and returned -1 for the case where ref1->ref_root was > than
ref2->ref_root.  This is a subtle bug that can result in improper
delayed ref running order, which can result in transaction aborts.

Fixes: cf4f0432 ("btrfs: move ->parent and ->ref_root into btrfs_delayed_ref_node")
CC: stable@vger.kernel.org # 6.10+
Reviewed-by: default avatarFilipe Manana <fdmanana@suse.com>
Reviewed-by: default avatarQu Wenruo <wqu@suse.com>
Signed-off-by: default avatarJosef Bacik <josef@toxicpanda.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 2b084d82

fs/btrfs/delayed-ref.c

+1 −1
Original line number Diff line number Diff line
@@ -298,7 +298,7 @@ static int comp_refs(struct btrfs_delayed_ref_node *ref1, 
		if (ref1->ref_root < ref2->ref_root)

			return -1;

		if (ref1->ref_root > ref2->ref_root)

			return -1;

			return 1;

		if (ref1->type == BTRFS_EXTENT_DATA_REF_KEY)

			ret = comp_data_refs(ref1, ref2);

	}