Commit 7d81afd2 authored by ye xingchen's avatar ye xingchen Committed by Vinod Koul
Browse files

dmaengine: sf-pdma:Remove the print function dev_err() 



>From the coccinelle check:

./drivers/dma/sf-pdma/sf-pdma.c
Error:line 409 is redundant because platform_get_irq() already prints an
error

./drivers/dma/sf-pdma/sf-pdma.c
Error:line 424 is redundant because platform_get_irq() already prints an
error

So,remove the unnecessary print function dev_err()

Reported-by: default avatarZeal Robot <zealci@zte.com.cn>
Signed-off-by: default avatarye xingchen <ye.xingchen@zte.com.cn>
Link: https://lore.kernel.org/r/20220810062532.13425-1-ye.xingchen@zte.com.cn


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 7c94dcfa

drivers/dma/sf-pdma/sf-pdma.c

+2 −6
Original line number Diff line number Diff line
@@ -405,10 +405,8 @@ static int sf_pdma_irq_init(struct platform_device *pdev, struct sf_pdma *pdma) 
		chan = &pdma->chans[i];



		irq = platform_get_irq(pdev, i * 2);

		if (irq < 0) {

			dev_err(&pdev->dev, "ch(%d) Can't get done irq.\n", i);

		if (irq < 0)

			return -EINVAL;

		}



		r = devm_request_irq(&pdev->dev, irq, sf_pdma_done_isr, 0,

				     dev_name(&pdev->dev), (void *)chan);
@@ -420,10 +418,8 @@ static int sf_pdma_irq_init(struct platform_device *pdev, struct sf_pdma *pdma) 
		chan->txirq = irq;



		irq = platform_get_irq(pdev, (i * 2) + 1);

		if (irq < 0) {

			dev_err(&pdev->dev, "ch(%d) Can't get err irq.\n", i);

		if (irq < 0)

			return -EINVAL;

		}



		r = devm_request_irq(&pdev->dev, irq, sf_pdma_err_isr, 0,

				     dev_name(&pdev->dev), (void *)chan);