Commit 7da14dea authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Tzung-Bi Shih
Browse files

firmware: google: gsmi: Constify 'struct bin_attribute' 



The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.

Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Acked-by: default avatarBrian Norris <briannorris@chromium.org>
Link: https://lore.kernel.org/r/20241215-sysfs-const-bin_attr-google-v1-2-e5c2808f5833@weissschuh.net


Signed-off-by: default avatarTzung-Bi Shih <tzungbi@kernel.org>
parent bf2066ca

drivers/firmware/google/gsmi.c

+3 −3
Original line number Diff line number Diff line
@@ -488,7 +488,7 @@ static const struct efivar_operations efivar_ops = { 
#endif /* CONFIG_EFI */



static ssize_t eventlog_write(struct file *filp, struct kobject *kobj,

			       struct bin_attribute *bin_attr,

			       const struct bin_attribute *bin_attr,

			       char *buf, loff_t pos, size_t count)

{

	struct gsmi_set_eventlog_param param = {
@@ -528,9 +528,9 @@ static ssize_t eventlog_write(struct file *filp, struct kobject *kobj, 


}



static struct bin_attribute eventlog_bin_attr = {

static const struct bin_attribute eventlog_bin_attr = {

	.attr = {.name = "append_to_eventlog", .mode = 0200},

	.write = eventlog_write,

	.write_new = eventlog_write,

};



static ssize_t gsmi_clear_eventlog_store(struct kobject *kobj,