Commit 7dbc0d40 authored by Dan Carpenter's avatar Dan Carpenter Committed by Thomas Gleixner
Browse files

irqchip/mchp-eic: Fix error code in mchp_eic_domain_alloc() 



If irq_domain_translate_twocell() sets "hwirq" to >= MCHP_EIC_NIRQ (2) then
it results in an out of bounds access.

The code checks for invalid values, but doesn't set the error code.  Return
-EINVAL in that case, instead of returning success.

Fixes: 00fa3461 ("irqchip/mchp-eic: Add support for the Microchip EIC")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Reviewed-by: default avatarClaudiu Beznea <claudiu.beznea@tuxon.dev>
Link: https://patch.msgid.link/aTfHmOz6IBpTIPU5@stanley.mountain
parent 55026a96

drivers/irqchip/irq-mchp-eic.c

+1 −1
Original line number Diff line number Diff line
@@ -170,7 +170,7 @@ static int mchp_eic_domain_alloc(struct irq_domain *domain, unsigned int virq, 


	ret = irq_domain_translate_twocell(domain, fwspec, &hwirq, &type);

	if (ret || hwirq >= MCHP_EIC_NIRQ)

		return ret;

		return ret ?: -EINVAL;



	switch (type) {

	case IRQ_TYPE_EDGE_RISING: