Commit 7dd1871e authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: tps65219: don't use CONFIG_DEBUG_GPIO 



CONFIG_DEBUG_GPIO should only be used to enable debug log messages and
for core GPIOLIB debugging. Don't use it to control the execution of
potentially buggy code. Just put it under an always-false #if.

Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 20bddcb4

drivers/gpio/gpio-tps65219.c

+9 −9
Original line number Diff line number Diff line
@@ -96,7 +96,7 @@ static int tps65219_gpio_change_direction(struct gpio_chip *gc, unsigned int off 
	 * Below can be used for test purpose only.

	 */



	if (IS_ENABLED(CONFIG_DEBUG_GPIO)) {

#if 0

	int ret = regmap_update_bits(gpio->tps->regmap, TPS65219_REG_MFP_1_CONFIG,

				     TPS65219_GPIO0_DIR_MASK, direction);

	if (ret) {
@@ -105,7 +105,7 @@ static int tps65219_gpio_change_direction(struct gpio_chip *gc, unsigned int off 
			direction, offset);

		return ret;

	}

	}

#endif



	dev_err(dev,

		"GPIO%d direction set by NVM, change to %u failed, not allowed by specification\n",