Commit 7dd9eb6b authored by Hardevsinh Palaniya's avatar Hardevsinh Palaniya Committed by Vineet Gupta
Browse files

ARC: bpf: Correct conditional check in 'check_jmp_32' 



The original code checks 'if (ARC_CC_AL)', which is always true since
ARC_CC_AL is a constant. This makes the check redundant and likely
obscures the intention of verifying whether the jump is conditional.

Updates the code to check cond == ARC_CC_AL instead, reflecting the intent
to differentiate conditional from unconditional jumps.

Suggested-by: default avatarVadim Fedorenko <vadim.fedorenko@linux.dev>
Reviewed-by: default avatarVadim Fedorenko <vadim.fedorenko@linux.dev>
Acked-by: default avatarShahab Vahedi <list+bpf@vahedi.org>
Signed-off-by: default avatarHardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>
Signed-off-by: default avatarVineet Gupta <vgupta@kernel.org>
parent 4d93ffe6

arch/arc/net/bpf_jit_arcv2.c

+1 −1
Original line number Diff line number Diff line
@@ -2916,7 +2916,7 @@ bool check_jmp_32(u32 curr_off, u32 targ_off, u8 cond) 
	addendum = (cond == ARC_CC_AL) ? 0 : INSN_len_normal;

	disp = get_displacement(curr_off + addendum, targ_off);



	if (ARC_CC_AL)

	if (cond == ARC_CC_AL)

		return is_valid_far_disp(disp);

	else

		return is_valid_near_disp(disp);