Unverified Commit 7dfc8f0c authored by David Howells's avatar David Howells Committed by Christian Brauner
Browse files

netfs: Fix netfs_release_folio() to say no if folio dirty 



Fix netfs_release_folio() to say no (ie. return false) if the folio is
dirty (analogous with iomap's behaviour).  Without this, it will say yes to
the release of a dirty page by split_huge_page_to_list_to_order(), which
will result in the loss of untruncated data in the folio.

Without this, the generic/075 and generic/112 xfstests (both fsx-based
tests) fail with minimum folio size patches applied[1].

Fixes: c1ec4d7c ("netfs: Provide invalidate_folio and release_folio calls")
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Link: https://lore.kernel.org/r/20240815090849.972355-1-kernel@pankajraghav.com/ [1]
Link: https://lore.kernel.org/r/20240823200819.532106-4-dhowells@redhat.com


cc: Matthew Wilcox (Oracle) <willy@infradead.org>
cc: Pankaj Raghav <p.raghav@samsung.com>
cc: Jeff Layton <jlayton@kernel.org>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
cc: netfs@lists.linux.dev
cc: linux-mm@kvack.org
cc: linux-fsdevel@vger.kernel.org
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent a74ee0e8

fs/netfs/misc.c

+3 −0
Original line number Diff line number Diff line
@@ -161,6 +161,9 @@ bool netfs_release_folio(struct folio *folio, gfp_t gfp) 
	struct netfs_inode *ctx = netfs_inode(folio_inode(folio));

	unsigned long long end;



	if (folio_test_dirty(folio))

		return false;



	end = folio_pos(folio) + folio_size(folio);

	if (end > ctx->zero_point)

		ctx->zero_point = end;