Commit 7dfe553a authored by Masahiro Yamada's avatar Masahiro Yamada Committed by Ingo Molnar
Browse files

x86/syscalls: Fix -Wmissing-prototypes warnings from COND_SYSCALL() 



Building kernel/sys_ni.c with W=1 emits tons of -Wmissing-prototypes warnings:

  $ make W=1 kernel/sys_ni.o
    [ snip ]
    CC      kernel/sys_ni.o
     ./arch/x86/include/asm/syscall_wrapper.h:83:14: warning: no previous prototype for '__ia32_sys_io_setup' [-Wmissing-prototypes]
     ...

The problem is in __COND_SYSCALL(), the __SYS_STUB0() and __SYS_STUBx() macros
defined a few lines above already have forward declarations.

Let's do likewise for __COND_SYSCALL() to fix the warnings.

Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Tested-by: default avatarMickaël Salaün <mic@linux.microsoft.com>
Link: https://lore.kernel.org/r/20210301131533.64671-2-masahiroy@kernel.org
parent 279d56ab

arch/x86/include/asm/syscall_wrapper.h

+1 −0
Original line number Diff line number Diff line
@@ -80,6 +80,7 @@ extern long __ia32_sys_ni_syscall(const struct pt_regs *regs); 
	}



#define __COND_SYSCALL(abi, name)					\

	__weak long __##abi##_##name(const struct pt_regs *__unused);	\

	__weak long __##abi##_##name(const struct pt_regs *__unused)	\

	{								\

		return sys_ni_syscall();				\