Commit 7e016cbc authored by Kishon Vijay Abraham I's avatar Kishon Vijay Abraham I Committed by Vinod Koul
Browse files

phy: cadence: Sierra: Move all clk_get_*() to a separate function 



No functional change. Group all devm_clk_get_optional() to a
separate function.

Signed-off-by: default avatarKishon Vijay Abraham I <kishon@ti.com>
Reviewed-by: default avatarSwapnil Jakhade <sjakhade@cadence.com>
Link: https://lore.kernel.org/r/20210319124128.13308-6-kishon@ti.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 3fb95456

drivers/phy/cadence/phy-cadence-sierra.c

+35 −22
Original line number Diff line number Diff line
@@ -477,6 +477,38 @@ static int cdns_regmap_init_blocks(struct cdns_sierra_phy *sp, 
	return 0;

}



static int cdns_sierra_phy_get_clocks(struct cdns_sierra_phy *sp,

				      struct device *dev)

{

	struct clk *clk;

	int ret;



	clk = devm_clk_get_optional(dev, "phy_clk");

	if (IS_ERR(clk)) {

		dev_err(dev, "failed to get clock phy_clk\n");

		return PTR_ERR(clk);

	}

	sp->clk = clk;



	clk = devm_clk_get_optional(dev, "cmn_refclk_dig_div");

	if (IS_ERR(clk)) {

		dev_err(dev, "cmn_refclk_dig_div clock not found\n");

		ret = PTR_ERR(clk);

		return ret;

	}

	sp->cmn_refclk_dig_div = clk;



	clk = devm_clk_get_optional(dev, "cmn_refclk1_dig_div");

	if (IS_ERR(clk)) {

		dev_err(dev, "cmn_refclk1_dig_div clock not found\n");

		ret = PTR_ERR(clk);

		return ret;

	}

	sp->cmn_refclk1_dig_div = clk;



	return 0;

}



static int cdns_sierra_phy_probe(struct platform_device *pdev)

{

	struct cdns_sierra_phy *sp;
@@ -487,7 +519,6 @@ static int cdns_sierra_phy_probe(struct platform_device *pdev) 
	unsigned int id_value;

	int i, ret, node = 0;

	void __iomem *base;

	struct clk *clk;

	struct device_node *dn = dev->of_node, *child;



	if (of_get_child_count(dn) == 0)
@@ -524,11 +555,9 @@ static int cdns_sierra_phy_probe(struct platform_device *pdev) 


	platform_set_drvdata(pdev, sp);



	sp->clk = devm_clk_get_optional(dev, "phy_clk");

	if (IS_ERR(sp->clk)) {

		dev_err(dev, "failed to get clock phy_clk\n");

		return PTR_ERR(sp->clk);

	}

	ret = cdns_sierra_phy_get_clocks(sp, dev);

	if (ret)

		return ret;



	sp->phy_rst = devm_reset_control_get(dev, "sierra_reset");

	if (IS_ERR(sp->phy_rst)) {
@@ -542,22 +571,6 @@ static int cdns_sierra_phy_probe(struct platform_device *pdev) 
		return PTR_ERR(sp->apb_rst);

	}



	clk = devm_clk_get_optional(dev, "cmn_refclk_dig_div");

	if (IS_ERR(clk)) {

		dev_err(dev, "cmn_refclk_dig_div clock not found\n");

		ret = PTR_ERR(clk);

		return ret;

	}

	sp->cmn_refclk_dig_div = clk;



	clk = devm_clk_get_optional(dev, "cmn_refclk1_dig_div");

	if (IS_ERR(clk)) {

		dev_err(dev, "cmn_refclk1_dig_div clock not found\n");

		ret = PTR_ERR(clk);

		return ret;

	}

	sp->cmn_refclk1_dig_div = clk;



	ret = clk_prepare_enable(sp->clk);

	if (ret)

		return ret;