Commit 7e18682b authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: spi/at73c213: Use guard() for spin locks 



Clean up the code using guard() for spin locks.

Merely code refactoring, and no behavior change.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 9fc4a3da

sound/spi/at73c213.c

+24 −28
Original line number Diff line number Diff line
@@ -273,9 +273,8 @@ static int snd_at73c213_pcm_trigger(struct snd_pcm_substream *substream, 
				   int cmd)

{

	struct snd_at73c213 *chip = snd_pcm_substream_chip(substream);

	int retval = 0;



	spin_lock(&chip->lock);

	guard(spinlock)(&chip->lock);



	switch (cmd) {

	case SNDRV_PCM_TRIGGER_START:
@@ -288,13 +287,11 @@ static int snd_at73c213_pcm_trigger(struct snd_pcm_substream *substream, 
		break;

	default:

		dev_dbg(&chip->spi->dev, "spurious command %x\n", cmd);

		retval = -EINVAL;

		return -EINVAL;

		break;

	}



	spin_unlock(&chip->lock);



	return retval;

	return 0;

}



static snd_pcm_uframes_t
@@ -358,8 +355,7 @@ static irqreturn_t snd_at73c213_interrupt(int irq, void *dev_id) 
	int next_period;

	int retval = IRQ_NONE;



	spin_lock(&chip->lock);



	scoped_guard(spinlock, &chip->lock) {

		block_size = frames_to_bytes(runtime, runtime->period_size);

		status = ssc_readl(chip->ssc->regs, IMR);
@@ -381,7 +377,7 @@ static irqreturn_t snd_at73c213_interrupt(int irq, void *dev_id) 
		}



		ssc_readl(chip->ssc->regs, IMR);

	spin_unlock(&chip->lock);

	}



	if (status & SSC_BIT(IMR_ENDTX))

		snd_pcm_period_elapsed(chip->substream);