Commit 7e1e45a9 authored by David Sterba's avatar David Sterba
Browse files

btrfs: remove duplicate calculation of eb offset in btrfs_bin_search() 



In the main search loop the variable 'oil' (offset in folio) is set
twice, one duplicated when the key fits completely to the contiguous
range. We can remove it and while it's just a simple calculation, the
binary search loop is executed many times so micro optimizations add up.

The code size is reduced by 64 bytes on release config, the loop is
reorganized a bit and a few instructions shorter.

Reviewed-by: default avatarBoris Burkov <boris@bur.io>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent b753612b

fs/btrfs/ctree.c

+0 −1
Original line number Diff line number Diff line
@@ -781,7 +781,6 @@ int btrfs_bin_search(const struct extent_buffer *eb, int first_slot, 
			const unsigned long idx = get_eb_folio_index(eb, offset);

			char *kaddr = folio_address(eb->folios[idx]);



			oil = get_eb_offset_in_folio(eb, offset);

			tmp = (struct btrfs_disk_key *)(kaddr + oil);

		} else {

			read_extent_buffer(eb, &unaligned, offset, key_size);