Commit 7e7f948c authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Jeff Johnson
Browse files

wifi: ath12k: Don't use %pK through printk 



In the past %pK was preferable to %p as it would not leak raw pointer
values into the kernel log.
Since commit ad67b74d ("printk: hash addresses printed with %p")
the regular %p has been improved to avoid this issue.
Furthermore, restricted pointers ("%pK") were never meant to be used
through printk(). They can still unintentionally leak raw pointers or
acquire sleeping looks in atomic contexts.

Switch to the regular pointer formatting which is safer and
easier to reason about.
There are still a few users of %pK left, but these use it through seq_file,
for which its usage is safe.

Signed-off-by: default avatarThomas Weißschuh <thomas.weissschuh@linutronix.de>
Reviewed-by: default avatarAleksandr Loktionov <aleksandr.loktionov@intel.com>
Link: https://patch.msgid.link/20250417-restricted-pointers-ath-v1-3-4e9a04dbe362@linutronix.de


Signed-off-by: default avatarJeff Johnson <jeff.johnson@oss.qualcomm.com>
parent 27c57c84

drivers/net/wireless/ath/ath12k/testmode.c

+2 −2
Original line number Diff line number Diff line
@@ -97,7 +97,7 @@ void ath12k_tm_process_event(struct ath12k_base *ab, u32 cmd_id, 
	u8 const *buf_pos;



	ath12k_dbg(ab, ATH12K_DBG_TESTMODE,

		   "testmode event wmi cmd_id %d ftm event msg %pK datalen %d\n",

		   "testmode event wmi cmd_id %d ftm event msg %p datalen %d\n",

		   cmd_id, ftm_msg, length);

	ath12k_dbg_dump(ab, ATH12K_DBG_TESTMODE, NULL, "", ftm_msg, length);

	pdev_id = DP_HW2SW_MACID(le32_to_cpu(ftm_msg->seg_hdr.pdev_id));
@@ -227,7 +227,7 @@ static int ath12k_tm_cmd_process_ftm(struct ath12k *ar, struct nlattr *tb[]) 
	buf_len = nla_len(tb[ATH_TM_ATTR_DATA]);

	cmd_id = WMI_PDEV_UTF_CMDID;

	ath12k_dbg(ar->ab, ATH12K_DBG_TESTMODE,

		   "testmode cmd wmi cmd_id %d buf %pK buf_len %d\n",

		   "testmode cmd wmi cmd_id %d buf %p buf_len %d\n",

		   cmd_id, buf, buf_len);

	ath12k_dbg_dump(ar->ab, ATH12K_DBG_TESTMODE, NULL, "", buf, buf_len);

	bufpos = buf;