Commit 7e9d619d authored by Rusty Russell's avatar Rusty Russell Committed by Avi Kivity
Browse files

KVM: Cleanup mark_page_dirty 



For some reason, mark_page_dirty open-codes __gfn_to_memslot().

Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
Signed-off-by: default avatarAvi Kivity <avi@qumranet.com>
parent fb764416

drivers/kvm/kvm_main.c

+7 −17
Original line number Diff line number Diff line
@@ -916,28 +916,18 @@ struct page *gfn_to_page(struct kvm *kvm, gfn_t gfn) 
}

EXPORT_SYMBOL_GPL(gfn_to_page);



/* WARNING: Does not work on aliased pages. */

void mark_page_dirty(struct kvm *kvm, gfn_t gfn)

{

	int i;

	struct kvm_memory_slot *memslot;

	unsigned long rel_gfn;



	for (i = 0; i < kvm->nmemslots; ++i) {

		memslot = &kvm->memslots[i];



		if (gfn >= memslot->base_gfn

		    && gfn < memslot->base_gfn + memslot->npages) {



			if (!memslot->dirty_bitmap)

				return;



			rel_gfn = gfn - memslot->base_gfn;

	memslot = __gfn_to_memslot(kvm, gfn);

	if (memslot && memslot->dirty_bitmap) {

		unsigned long rel_gfn = gfn - memslot->base_gfn;



		/* avoid RMW */

		if (!test_bit(rel_gfn, memslot->dirty_bitmap))

			set_bit(rel_gfn, memslot->dirty_bitmap);

			return;

		}

	}

}