Commit 7ece381a authored by Richard Fitzgerald's avatar Richard Fitzgerald Committed by Shuah Khan
Browse files

kunit: Protect string comparisons against NULL 



Add NULL checks to KUNIT_BINARY_STR_ASSERTION() so that it will fail
cleanly if either pointer is NULL, instead of causing a NULL pointer
dereference in the strcmp().

A test failure could be that a string is unexpectedly NULL. This could
be trapped by KUNIT_ASSERT_NOT_NULL() but that would terminate the test
at that point. It's preferable that the KUNIT_EXPECT_STR*() macros can
handle NULL pointers as a failure.

Signed-off-by: default avatarRichard Fitzgerald <rf@opensource.cirrus.com>
Reviewed-by: default avatarDavid Gow <davidgow@google.com>
Reviewed-by: default avatarMuhammad Usama Anjum <usama.anjum@collabora.com>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
parent 5fb1a8c6

include/kunit/test.h

+1 −1
Original line number Diff line number Diff line
@@ -758,7 +758,7 @@ do { \ 
		.right_text = #right,					       \

	};								       \

									       \

	if (likely(strcmp(__left, __right) op 0))			       \

	if (likely((__left) && (__right) && (strcmp(__left, __right) op 0)))   \

		break;							       \

									       \

									       \