Commit 7ef3cbf1 authored by Mark Harmstone's avatar Mark Harmstone Committed by David Sterba
Browse files

btrfs: avoid linker error in btrfs_find_create_tree_block() 



The inline function btrfs_is_testing() is hardcoded to return 0 if
CONFIG_BTRFS_FS_RUN_SANITY_TESTS is not set. Currently we're relying on
the compiler optimizing out the call to alloc_test_extent_buffer() in
btrfs_find_create_tree_block(), as it's not been defined (it's behind an
 #ifdef).

Add a stub version of alloc_test_extent_buffer() to avoid linker errors
on non-standard optimization levels. This problem was seen on GCC 14
with -O0 and is helps to see symbols that would be otherwise optimized
out.

Reviewed-by: default avatarQu Wenruo <wqu@suse.com>
Signed-off-by: default avatarMark Harmstone <maharmstone@fb.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent df94a342

fs/btrfs/extent_io.c

+5 −2
Original line number Diff line number Diff line
@@ -3006,10 +3006,10 @@ struct extent_buffer *find_extent_buffer(struct btrfs_fs_info *fs_info, 
	return eb;

}



#ifdef CONFIG_BTRFS_FS_RUN_SANITY_TESTS

struct extent_buffer *alloc_test_extent_buffer(struct btrfs_fs_info *fs_info,

					u64 start)

{

#ifdef CONFIG_BTRFS_FS_RUN_SANITY_TESTS

	struct extent_buffer *eb, *exists = NULL;

	int ret;
@@ -3045,8 +3045,11 @@ struct extent_buffer *alloc_test_extent_buffer(struct btrfs_fs_info *fs_info, 
free_eb:

	btrfs_release_extent_buffer(eb);

	return exists;

}

#else

	/* Stub to avoid linker error when compiled with optimizations turned off. */

	return NULL;

#endif

}



static struct extent_buffer *grab_extent_buffer(struct btrfs_fs_info *fs_info,

						struct folio *folio)