Commit 7f02b8a5 authored by Javier Carrasco's avatar Javier Carrasco Committed by Greg Kroah-Hartman
Browse files

usb: typec: qcom-pmic-typec: use fwnode_handle_put() to release fwnodes 



The right function to release a fwnode acquired via
device_get_named_child_node() is fwnode_handle_put(), and not
fwnode_remove_software_node(), as no software node is being handled.

Replace the calls to fwnode_remove_software_node() with
fwnode_handle_put() in qcom_pmic_typec_probe() and
qcom_pmic_typec_remove().

Cc: stable@vger.kernel.org
Fixes: a4422ff2 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver")
Suggested-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: default avatarJavier Carrasco <javier.carrasco.cruz@gmail.com>
Acked-by: default avatarBryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20241020-qcom_pmic_typec-fwnode_remove-v2-1-7054f3d2e215@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 623dae3e

drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c

+2 −2
Original line number Diff line number Diff line
@@ -123,7 +123,7 @@ static int qcom_pmic_typec_probe(struct platform_device *pdev) 
port_unregister:

	tcpm_unregister_port(tcpm->tcpm_port);

fwnode_remove:

	fwnode_remove_software_node(tcpm->tcpc.fwnode);

	fwnode_handle_put(tcpm->tcpc.fwnode);



	return ret;

}
@@ -135,7 +135,7 @@ static void qcom_pmic_typec_remove(struct platform_device *pdev) 
	tcpm->pdphy_stop(tcpm);

	tcpm->port_stop(tcpm);

	tcpm_unregister_port(tcpm->tcpm_port);

	fwnode_remove_software_node(tcpm->tcpc.fwnode);

	fwnode_handle_put(tcpm->tcpc.fwnode);

}



static const struct pmic_typec_resources pm8150b_typec_res = {