Commit 7f1ee4e2 authored by Hugh Dickins's avatar Hugh Dickins Committed by Andrew Morton
Browse files

mempolicy trivia: delete those ancient pr_debug()s 

Delete those ancient pr_debug()s - PDprintk()s in Andi Kleen's original
submission of core NUMA API, and useful when debugging shared mempolicy
lifetime back then, but not used recently.

Link: https://lkml.kernel.org/r/f25135-ffb2-40d8-9577-720772b333@google.com


Signed-off-by: default avatarHugh Dickins <hughd@google.com>
Reviewed-by: default avatarMatthew Wilcox (Oracle) <willy@infradead.org>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Christoph Lameter <cl@linux.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Huang, Ying" <ying.huang@intel.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Mel Gorman <mgorman@techsingularity.net>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Nhat Pham <nphamcs@gmail.com>
Cc: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Tejun heo <tj@kernel.org>
Cc: Vishal Moola (Oracle) <vishal.moola@gmail.com>
Cc: Yang Shi <shy828301@gmail.com>
Cc: Yosry Ahmed <yosryahmed@google.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 1cb5d11a

mm/mempolicy.c

+0 −21
Original line number Diff line number Diff line
@@ -264,9 +264,6 @@ static struct mempolicy *mpol_new(unsigned short mode, unsigned short flags, 
{

	struct mempolicy *policy;



	pr_debug("setting mode %d flags %d nodes[0] %lx\n",

		 mode, flags, nodes ? nodes_addr(*nodes)[0] : NUMA_NO_NODE);



	if (mode == MPOL_DEFAULT) {

		if (nodes && !nodes_empty(*nodes))

			return ERR_PTR(-EINVAL);
@@ -768,11 +765,6 @@ static int vma_replace_policy(struct vm_area_struct *vma, 


	vma_assert_write_locked(vma);



	pr_debug("vma %lx-%lx/%lx vm_ops %p vm_file %p set_policy %p\n",

		 vma->vm_start, vma->vm_end, vma->vm_pgoff,

		 vma->vm_ops, vma->vm_file,

		 vma->vm_ops ? vma->vm_ops->set_policy : NULL);



	new = mpol_dup(pol);

	if (IS_ERR(new))

		return PTR_ERR(new);
@@ -1273,10 +1265,6 @@ static long do_mbind(unsigned long start, unsigned long len, 
	if (!new)

		flags |= MPOL_MF_DISCONTIG_OK;



	pr_debug("mbind %lx-%lx mode:%d flags:%d nodes:%lx\n",

		 start, start + len, mode, mode_flags,

		 nmask ? nodes_addr(*nmask)[0] : NUMA_NO_NODE);



	if (flags & (MPOL_MF_MOVE | MPOL_MF_MOVE_ALL))

		lru_cache_disable();

	{
@@ -2496,8 +2484,6 @@ static void sp_insert(struct shared_policy *sp, struct sp_node *new) 
	}

	rb_link_node(&new->nd, parent, p);

	rb_insert_color(&new->nd, &sp->root);

	pr_debug("inserting %lx-%lx: %d\n", new->start, new->end,

		 new->policy ? new->policy->mode : 0);

}



/* Find shared policy intersecting idx */
@@ -2636,7 +2622,6 @@ void mpol_put_task_policy(struct task_struct *task) 


static void sp_delete(struct shared_policy *sp, struct sp_node *n)

{

	pr_debug("deleting %lx-l%lx\n", n->start, n->end);

	rb_erase(&n->nd, &sp->root);

	sp_free(n);

}
@@ -2793,12 +2778,6 @@ int mpol_set_shared_policy(struct shared_policy *info, 
	struct sp_node *new = NULL;

	unsigned long sz = vma_pages(vma);



	pr_debug("set_shared_policy %lx sz %lu %d %d %lx\n",

		 vma->vm_pgoff,

		 sz, npol ? npol->mode : -1,

		 npol ? npol->flags : -1,

		 npol ? nodes_addr(npol->nodes)[0] : NUMA_NO_NODE);



	if (npol) {

		new = sp_alloc(vma->vm_pgoff, vma->vm_pgoff + sz, npol);

		if (!new)