Commit 7f335744 authored by Hugo Villeneuve's avatar Hugo Villeneuve Committed by Greg Kroah-Hartman
Browse files

serial: sc16is7xx: unconditionally clear line bit in sc16is7xx_remove() 



There is no need to check for previous port registration in
sc16is7xx_remove() because if sc16is7xx_probe() succeeded, we are
guaranteed to have successfully registered both ports. We can thus
unconditionally clear the line allocation bit in sc16is7xx_lines.

Signed-off-by: default avatarHugo Villeneuve <hvilleneuve@dimonoff.com>
Reviewed-by: default avatarAndy Shevchenko <andy@kernel.org>
Link: https://lore.kernel.org/r/20240409154253.3043822-3-hugo@hugovil.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2a8e4ab0

drivers/tty/serial/sc16is7xx.c

+2 −2
Original line number Diff line number Diff line
@@ -1660,7 +1660,7 @@ static void sc16is7xx_remove(struct device *dev) 


	for (i = 0; i < s->devtype->nr_uart; i++) {

		kthread_cancel_delayed_work_sync(&s->p[i].ms_work);

		if (test_and_clear_bit(s->p[i].port.line, sc16is7xx_lines))

		clear_bit(s->p[i].port.line, sc16is7xx_lines);

		uart_remove_one_port(&sc16is7xx_uart, &s->p[i].port);

		sc16is7xx_power(&s->p[i].port, 0);

	}