Commit 7f482126 authored by Jan Kara's avatar Jan Kara Committed by Theodore Ts'o
Browse files

ext4: drop duplicate ea_inode handling in ext4_xattr_block_set() 



ext4_xattr_block_set() drops ea_inode reference in two places. Handling
it just under the 'cleanup' label is enough so drop the second
occurence.

Signed-off-by: default avatarJan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20240209112107.10585-3-jack@suse.cz


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 8208c41c

fs/ext4/xattr.c

+0 −11
Original line number Diff line number Diff line
@@ -2158,17 +2158,6 @@ ext4_xattr_block_set(handle_t *handle, struct inode *inode, 
						      ENTRY(header(s->base)+1));

			if (error)

				goto getblk_failed;

			if (ea_inode) {

				/* Drop the extra ref on ea_inode. */

				error = ext4_xattr_inode_dec_ref(handle,

								 ea_inode);

				if (error)

					ext4_warning_inode(ea_inode,

							   "dec ref error=%d",

							   error);

				iput(ea_inode);

				ea_inode = NULL;

			}



			lock_buffer(new_bh);

			error = ext4_journal_get_create_access(handle, sb,