Commit 7f5d956d authored by Nuno Sa's avatar Nuno Sa Committed by Jonathan Cameron
Browse files

iio: imu: adis16480: drop ifdef around CONFIG_DEBUG_FS 



Use IS_ENABLED(CONFIG_DEBUG_FS) to return in case debugfs is not present.
Since this is known at compile time, it allows the compiler to drop any
unused code. Therefore no need to wrap the code with #ifdef.

While at it make adis16480_debugfs_init() void as the return code is
ignored.

Signed-off-by: default avatarNuno Sa <nuno.sa@analog.com>
Link: https://patch.msgid.link/20240809-dev-adis-debugfs-improv-v1-2-d3adb6996518@analog.com


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent cec920f6

drivers/iio/imu/adis16480.c

+4 −14
Original line number Diff line number Diff line
@@ -193,8 +193,6 @@ module_param(low_rate_allow, bool, 0444); 
MODULE_PARM_DESC(low_rate_allow,

		 "Allow IMU rates below the minimum advisable when external clk is used in PPS mode (default: N)");



#ifdef CONFIG_DEBUG_FS



static ssize_t adis16480_show_firmware_revision(struct file *file,

		char __user *userbuf, size_t count, loff_t *ppos)

{
@@ -304,11 +302,14 @@ static int adis16480_show_flash_count(void *arg, u64 *val) 
DEFINE_DEBUGFS_ATTRIBUTE(adis16480_flash_count_fops,

	adis16480_show_flash_count, NULL, "%lld\n");



static int adis16480_debugfs_init(struct iio_dev *indio_dev)

static void adis16480_debugfs_init(struct iio_dev *indio_dev)

{

	struct adis16480 *adis16480 = iio_priv(indio_dev);

	struct dentry *d = iio_get_debugfs_dentry(indio_dev);



	if (!IS_ENABLED(CONFIG_DEBUG_FS))

		return;



	debugfs_create_file_unsafe("firmware_revision", 0400,

		d, adis16480, &adis16480_firmware_revision_fops);

	debugfs_create_file_unsafe("firmware_date", 0400,
@@ -319,19 +320,8 @@ static int adis16480_debugfs_init(struct iio_dev *indio_dev) 
		d, adis16480, &adis16480_product_id_fops);

	debugfs_create_file_unsafe("flash_count", 0400,

		d, adis16480, &adis16480_flash_count_fops);



	return 0;

}



#else



static int adis16480_debugfs_init(struct iio_dev *indio_dev)

{

	return 0;

}



#endif



static int adis16480_set_freq(struct iio_dev *indio_dev, int val, int val2)

{

	struct adis16480 *st = iio_priv(indio_dev);