Commit 7f5dce6e authored by Karan Tilak Kumar's avatar Karan Tilak Kumar Committed by Martin K. Petersen
Browse files

scsi: fnic: Replace fnic->lock_flags with local flags 



Replace fnic->lock_flags with local variable for usage with spinlocks in
fdls_schedule_oxid_free_retry_work().

Suggested-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Fixes: a63e78eb ("scsi: fnic: Add support for fabric based solicited requests and responses")
Reviewed-by: default avatarSesidhar Baddela <sebaddel@cisco.com>
Reviewed-by: default avatarArulprabhu Ponnusamy <arulponn@cisco.com>
Reviewed-by: default avatarGian Carlo Boffa <gcboffa@cisco.com>
Reviewed-by: default avatarArun Easi <aeasi@cisco.com>
Signed-off-by: default avatarKaran Tilak Kumar <kartilak@cisco.com>
Link: https://lore.kernel.org/r/20250301013712.3115-1-kartilak@cisco.com


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent e984fa25

drivers/scsi/fnic/fdls_disc.c

+6 −5
Original line number Diff line number Diff line
@@ -308,23 +308,24 @@ void fdls_schedule_oxid_free_retry_work(struct work_struct *work) 
	struct fnic *fnic = iport->fnic;

	struct reclaim_entry_s *reclaim_entry;

	unsigned long delay_j = msecs_to_jiffies(OXID_RECLAIM_TOV(iport));

	unsigned long flags;

	int idx;



	spin_lock_irqsave(&fnic->fnic_lock, fnic->lock_flags);

	spin_lock_irqsave(&fnic->fnic_lock, flags);



	for_each_set_bit(idx, oxid_pool->pending_schedule_free, FNIC_OXID_POOL_SZ) {



		FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num,

			"Schedule oxid free. oxid idx: %d\n", idx);



		spin_unlock_irqrestore(&fnic->fnic_lock, fnic->lock_flags);

		spin_unlock_irqrestore(&fnic->fnic_lock, flags);

		reclaim_entry = kzalloc(sizeof(*reclaim_entry), GFP_KERNEL);

		spin_lock_irqsave(&fnic->fnic_lock, fnic->lock_flags);

		spin_lock_irqsave(&fnic->fnic_lock, flags);



		if (!reclaim_entry) {

			schedule_delayed_work(&oxid_pool->schedule_oxid_free_retry,

				msecs_to_jiffies(SCHEDULE_OXID_FREE_RETRY_TIME));

			spin_unlock_irqrestore(&fnic->fnic_lock, fnic->lock_flags);

			spin_unlock_irqrestore(&fnic->fnic_lock, flags);

			return;

		}
@@ -339,7 +340,7 @@ void fdls_schedule_oxid_free_retry_work(struct work_struct *work) 
		}

	}



	spin_unlock_irqrestore(&fnic->fnic_lock, fnic->lock_flags);

	spin_unlock_irqrestore(&fnic->fnic_lock, flags);

}



static bool fdls_is_oxid_fabric_req(uint16_t oxid)