Commit 7fa9fbf3 authored by Hector Martin's avatar Hector Martin Committed by Manivannan Sadhasivam
Browse files

PCI: apple: Fix missing OF node reference in apple_pcie_setup_port 



In the success path, we hang onto a reference to the node, so make sure
to grab one. The caller iterator puts our borrowed reference when we
return.

Signed-off-by: default avatarHector Martin <marcan@marcan.st>
Signed-off-by: default avatarAlyssa Rosenzweig <alyssa@rosenzweig.io>
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Tested-by: default avatarJanne Grunau <j@jannau.net>
Reviewed-by: default avatarRob Herring (Arm) <robh@kernel.org>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Acked-by: default avatarAlyssa Rosenzweig <alyssa@rosenzweig.io>
Link: https://patch.msgid.link/20250401091713.2765724-9-maz@kernel.org
parent 0411c90e

drivers/pci/controller/pcie-apple.c

+3 −0
Original line number Diff line number Diff line
@@ -593,6 +593,9 @@ static int apple_pcie_setup_port(struct apple_pcie *pcie, 
	list_add_tail(&port->entry, &pcie->ports);

	init_completion(&pcie->event);



	/* In the success path, we keep a reference to np around */

	of_node_get(np);



	ret = apple_pcie_port_register_irqs(port);

	WARN_ON(ret);