Unverified Commit 7ff01ca7 authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown
Browse files

ASoC: SOF: Intel: hda: list SoundWire peripherals on mismatch 



Most of the SoundWire support issues come from bad ACPI information,
or configuration reported by ACPI that are not supported by the SOF
driver/topology. The users see a "No SoundWire machine driver found"
message without any details, and the fallback to HDaudio w/ HDMI is
used.

We can reduce our support load with a clear dev_info() log that will
give us a clear hint on the mismatch and why a machine driver/topology
were not found.

Example log on a MTL device:
[   13.158599] sof-audio-pci-intel-mtl 0000:00:1f.3: No SoundWire machine driver found for the ACPI-reported configuration:
[   13.158603] sof-audio-pci-intel-mtl 0000:00:1f.3: link 0 mfg_id 0x025d part_id 0x0713 version 0x3
[   13.158606] sof-audio-pci-intel-mtl 0000:00:1f.3: link 1 mfg_id 0x025d part_id 0x1316 version 0x3
[   13.158608] sof-audio-pci-intel-mtl 0000:00:1f.3: link 2 mfg_id 0x025d part_id 0x1316 version 0x3

In parallel, we will also provide an update to `alsa-info` to log all
SoundWire peripherals found in ACPI tables.

Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20240426153902.39560-5-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 5d4788b2

sound/soc/sof/intel/hda.c

+16 −1
Original line number Diff line number Diff line
@@ -1645,6 +1645,7 @@ static struct snd_soc_acpi_mach *hda_sdw_machine_select(struct snd_sof_dev *sdev 
{

	struct snd_sof_pdata *pdata = sdev->pdata;

	const struct snd_soc_acpi_link_adr *link;

	struct sdw_extended_slave_id *ids;

	struct snd_soc_acpi_mach *mach;

	struct sof_intel_hda_dev *hdev;

	u32 link_mask;
@@ -1658,6 +1659,16 @@ static struct snd_soc_acpi_mach *hda_sdw_machine_select(struct snd_sof_dev *sdev 
		return NULL;

	}



	if (!hdev->sdw) {

		dev_dbg(sdev->dev, "SoundWire context not allocated\n");

		return NULL;

	}



	if (!hdev->sdw->num_slaves) {

		dev_warn(sdev->dev, "No SoundWire peripheral detected in ACPI tables\n");

		return NULL;

	}



	/*

	 * Select SoundWire machine driver if needed using the

	 * alternate tables. This case deals with SoundWire-only
@@ -1740,7 +1751,11 @@ static struct snd_soc_acpi_mach *hda_sdw_machine_select(struct snd_sof_dev *sdev 
		return mach;

	}



	dev_info(sdev->dev, "No SoundWire machine driver found\n");

	dev_info(sdev->dev, "No SoundWire machine driver found for the ACPI-reported configuration:\n");

	ids = hdev->sdw->ids;

	for (i = 0; i < hdev->sdw->num_slaves; i++)

		dev_info(sdev->dev, "link %d mfg_id 0x%04x part_id 0x%04x version %#x\n",

			 ids[i].link_id, ids[i].id.mfg_id, ids[i].id.part_id, ids[i].id.sdw_version);



	return NULL;

}