Unverified Commit 7ff2fecc authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Ilpo Järvinen
Browse files

platform/x86/intel/pmt: Constify 'struct bin_attribute' 



The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.

Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Link: https://lore.kernel.org/r/20241202-sysfs-const-bin_attr-pdx86-v1-4-9ab204c2a814@weissschuh.net


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent b0034f20

drivers/platform/x86/intel/pmt/class.c

+2 −2
Original line number Diff line number Diff line
@@ -81,7 +81,7 @@ EXPORT_SYMBOL_NS_GPL(pmt_telem_read_mmio, "INTEL_PMT"); 
 */

static ssize_t

intel_pmt_read(struct file *filp, struct kobject *kobj,

	       struct bin_attribute *attr, char *buf, loff_t off,

	       const struct bin_attribute *attr, char *buf, loff_t off,

	       size_t count)

{

	struct intel_pmt_entry *entry = container_of(attr,
@@ -308,7 +308,7 @@ static int intel_pmt_dev_register(struct intel_pmt_entry *entry, 
	entry->pmt_bin_attr.attr.name = ns->name;

	entry->pmt_bin_attr.attr.mode = 0440;

	entry->pmt_bin_attr.mmap = intel_pmt_mmap;

	entry->pmt_bin_attr.read = intel_pmt_read;

	entry->pmt_bin_attr.read_new = intel_pmt_read;

	entry->pmt_bin_attr.size = entry->size;



	ret = sysfs_create_bin_file(&dev->kobj, &entry->pmt_bin_attr);